{ARM} Move deployments-owned custom commands into separate file#31432
{ARM} Move deployments-owned custom commands into separate file#31432anthony-c-martin wants to merge 2 commits intoAzure:devfrom
Conversation
anthony-c-martin
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @anthony-c-martin, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
ARM
anthony-c-martin
force-pushed
the
ant/move
branch
3 times, most recently
from
ac2308d to
f1ac337
Compare
|
@yonzhan please could you run tests for this? |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@zhoxing-ms please could you take a look? |
|
May I ask what the purpose of this PR is? Is this to avoid too many unrelated modules being affected by the api-version bumping of Resource module? |
Just for code organization - I wanted to centralize all of the commands owned by my team in one place ( In terms of how it's implemented - I'm not a Python expert, so please let me know if there's a better way. |
|
But I see a lot of duplicate code appearing in |
anthony-c-martin
force-pushed
the
ant/move
branch
from
f1ac337 to
c3fb3a3
Compare
I've pushed an update to remove the duplication |
|
@yonzhan please could you re-run tests for this? @zhoxing-ms assuming checks pass - any objections to merging this soon? It's a pure refactor - I'm not changing any functionality. We have some feature work we'd like to start on in this repo, so it would be ideal if we could complete this before starting the feature work. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
@zhoxing-ms - reminder on this |
|
@anthony-c-martin Could you please re-run some deployment related tests in live mode to check if it meets expectations, because there are big code changes to this PR, we'd better be more cautious |
There are a large number of failures even when I run the live tests against the |
4 participants
Related command
az deployment ...Description
Non-functional refactor to move deployments-owned custom commands into separate file
Testing Guide
This PR relies on the existing tests.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.